Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/4891#discussion_r146336120
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/execution/librarycache/FlinkUserCodeClassLoaders.java
---
@@ -31,24 +31,23 @@
*/
public class FlinkUserCodeClassLoaders {
- public static URLClassLoader parentFirst(URL[] urls) {
- return new ParentFirstClassLoader(urls);
- }
-
public static URLClassLoader parentFirst(URL[] urls, ClassLoader
parent) {
return new ParentFirstClassLoader(urls, parent);
}
- public static URLClassLoader childFirst(URL[] urls, ClassLoader parent)
{
- return new ChildFirstClassLoader(urls, parent);
+ public static URLClassLoader childFirst(
+ URL[] urls,
+ ClassLoader parent,
+ String[] alwaysParentFirstPatterns) {
+ return new ChildFirstClassLoader(urls, parent,
alwaysParentFirstPatterns);
}
public static URLClassLoader create(
- ResolveOrder resolveOrder, URL[] urls, ClassLoader parent) {
+ ResolveOrder resolveOrder, URL[] urls, ClassLoader parent,
String[] alwaysParentFirstPatterns) {
--- End diff --
Make this a vararg parameter for nice APIs during testing ?
---
