Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4891#discussion_r146504815
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobManagerServices.java
 ---
    @@ -116,8 +116,15 @@ public static JobManagerServices fromConfiguration(
                final String classLoaderResolveOrder =
                        config.getString(CoreOptions.CLASSLOADER_RESOLVE_ORDER);
     
    +           final String alwaysParentFirstLoaderString =
    --- End diff --
    
    The parameter cannot be `null`, since there is a default value. If it is 
empty, won't `split` simply return an empty array?
    
    I made a comment about this below, i.e. where we should handle parsing of 
config options.


---

Reply via email to