[
https://issues.apache.org/jira/browse/FLINK-7883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16216684#comment-16216684
]
Aljoscha Krettek commented on FLINK-7883:
-----------------------------------------
[~aphilippot] Please have a look at the discussion started roughly here:
https://lists.apache.org/thread.html/a81b88ccdac36d86a7760461be315cdc7c7f441d31bef317b3ffa320@%3Cuser.flink.apache.org%3E
I think the current source interface is not well suited to what you want to
achieve. The new proposed interface would have the functionality of a
"stoppable source" built in, it could be stopped by the task simply not trying
to pull data from it anymore.
This is a somewhat bigger undertaking but if you have time and are interested I
would be very eager to work out a design for this and help in implementation.
What do you think?
> Stop fetching source before a cancel with savepoint
> ---------------------------------------------------
>
> Key: FLINK-7883
> URL: https://issues.apache.org/jira/browse/FLINK-7883
> Project: Flink
> Issue Type: Improvement
> Components: DataStream API, Kafka Connector, State Backends,
> Checkpointing
> Affects Versions: 1.4.0, 1.3.2
> Reporter: Antoine Philippot
>
> For a cancel with savepoint command, the JobManager trigger the cancel call
> once the savepoint is finished, but during the savepoint execution, kafka
> source continue to poll new messages which will not be part of the savepoint
> and will be replayed on the next application start.
> A solution could be to stop fetching the source stream task before triggering
> the savepoint.
> I suggest to add an interface {{StoppableFetchingSourceFunction}} with a
> method {{stopFetching}} that existant SourceFunction implementations could
> implement.
> We can add a {{stopFetchingSource}} property in
> {{CheckpointOptions}} class to pass the desired behaviour from
> {{JobManager.handleMessage(CancelJobWithSavepoint)}} to
> {{SourceStreamTask.triggerCheckpoint}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
