[GitHub] flink pull request #4891: [FLINK-7669] Always load Flink classes via parent ...

[StephanEwen]

Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4891#discussion_r146573737
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobManagerServices.java
 ---
    @@ -116,8 +116,15 @@ public static JobManagerServices fromConfiguration(
                final String classLoaderResolveOrder =
                        config.getString(CoreOptions.CLASSLOADER_RESOLVE_ORDER);
     
    +           final String alwaysParentFirstLoaderString =
    +                   
config.getString(CoreOptions.ALWAYS_PARENT_FIRST_LOADER);
    +           final String[] alwaysParentFirstLoaderPatterns = 
alwaysParentFirstLoaderString.split(",");
    +
                final BlobLibraryCacheManager libraryCacheManager =
    -                   new BlobLibraryCacheManager(blobServer, 
FlinkUserCodeClassLoaders.ResolveOrder.fromString(classLoaderResolveOrder));
    +                   new BlobLibraryCacheManager(
    +                           blobServer,
    +                           
FlinkUserCodeClassLoaders.ResolveOrder.fromString(classLoaderResolveOrder),
    --- End diff --
    
    Okay, that works.


---