Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4827#discussion_r146986377
  
    --- Diff: flink-runtime/pom.xml ---
    @@ -427,17 +427,42 @@ under the License.
                                                        <goal>shade</goal>
                                                </goals>
                                                <configuration>
    +                                                   <!-- we need this to 
avoid having to specify all of akka's dependencies -->
    +                                                   
<promoteTransitiveDependencies>true</promoteTransitiveDependencies>
    --- End diff --
    
    Why exactly do we need this? AFAIK you can shade transitive dependencies 
without promoting them.


---

Reply via email to