Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/4827#discussion_r147087742
--- Diff: flink-runtime/pom.xml ---
@@ -427,17 +427,42 @@ under the License.
<goal>shade</goal>
</goals>
<configuration>
+ <!-- we need this to
avoid having to specify all of akka's dependencies -->
+
<promoteTransitiveDependencies>true</promoteTransitiveDependencies>
--- End diff --
This adds `akka-remote`'s dependencies as direct dependencies to
`flink-runtime` (like for example `reactive-streams`).
Without promoting transitive dependencies, we would need to add all
transitive dependencies of `akka-remote` to the shaded jar, because
`akka-remote` is removed as a dependency which also removes its transitive
dependencies.
We could do that, but since we cannot relocate many of them (Scala) I
though to keep the set of dependencies that are "present but undeclared" small
and treat akka-remote's dependencies like regular dependencies.
---
