Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/4907#discussion_r147091056 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/filesystem/FsStateBackendFactory.java --- @@ -18,45 +18,41 @@ package org.apache.flink.runtime.state.filesystem; +import org.apache.flink.annotation.PublicEvolving; +import org.apache.flink.configuration.CheckpointingOptions; import org.apache.flink.configuration.Configuration; import org.apache.flink.configuration.IllegalConfigurationException; import org.apache.flink.core.fs.Path; import org.apache.flink.runtime.state.StateBackendFactory; -import java.io.IOException; +import java.net.URI; /** - * A factory that creates an {@link org.apache.flink.runtime.state.filesystem.FsStateBackend} - * from a configuration. + * A factory that creates an {@link FsStateBackend} from a configuration. */ +@PublicEvolving public class FsStateBackendFactory implements StateBackendFactory<FsStateBackend> { - - /** The key under which the config stores the directory where checkpoints should be stored */ - public static final String CHECKPOINT_DIRECTORY_URI_CONF_KEY = "state.backend.fs.checkpointdir"; - - /** The key under which the config stores the threshold for state to be store in memory, - * rather than in files */ - public static final String MEMORY_THRESHOLD_CONF_KEY = "state.backend.fs.memory-threshold"; - @Override public FsStateBackend createFromConfig(Configuration config) throws IllegalConfigurationException { --- End diff -- One could for those that we currently have, agreed. I would like to keep the factories, though, for future backends (or user-defined backends) that do not implement reconfiguration.
---