Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4872#discussion_r147656394
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServices.java
---
@@ -163,12 +156,14 @@ public JobLeaderService getJobLeaderService() {
*
* @param resourceID resource ID of the task manager
* @param taskManagerServicesConfiguration task manager configuration
+ * @param metricRegistry to register the TaskManagerMetricGroup
* @return task manager components
* @throws Exception
*/
public static TaskManagerServices fromConfiguration(
--- End diff --
Seems a bit dirty that the `fromConfiguration` method accepts a
non-configuration object.
---
