GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/4921

    [FLINK-7943] Make ParameterTool thread safe

    ## What is the purpose of the change
    
    This commit changes the serialization of the ParameterTool such that only 
the
    data map is contained. The defaultData and the unrequestedParameters maps 
are
    not serialized because they are only used on the client side. Additionally, 
the
    defaultData and unrequestedParameters map are being made thread safe by 
using
    ConcurrentHashMaps.
    
    ## Verifying this change
    
    - Added `ParameterToolTest#testConcurrentExecutionConfigSerialization`
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink copyParameterTool

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4921.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4921
    
----

----


---

Reply via email to