Github user tillrohrmann commented on the issue:

    https://github.com/apache/flink/pull/4921
  
    Thanks for the review @zentol. Yes you're right that this PR has failing 
test cases. I wasn't aware that the `ParameterTool` is so messy (getters with 
side effects, storing default values for future gets, counting which parameters 
have been accessed, sending this whole thing over to the cluster) and that the 
`RequiredParameters` change the `ParameterTool` directly. I'm currently 
thinking about letting the `RequiredParameters` create a new `ParameterTool` if 
they have to change a value. Ideally, I would like to remove 
`RequiredParameters` and do not send the `ParameterTool` to the cluster.


---

Reply via email to