Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4928#discussion_r148204574
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/KafkaTopicPartitionStateSentinel.java
---
@@ -52,4 +52,7 @@
*/
public static final long GROUP_OFFSET = -915623761773L;
+ public static boolean isSentinel(long offset) {
+ return offset < 0;
--- End diff --
nit: this implementation could be a bit too broad. Could be a bit more
specific by matching the static values in `KafkaTopicPartitionStateSentinel`.
---
