[GitHub] flink pull request #4928: [FLINK-7732][kafka-consumer] Do not commit to kafk...

[tzulitai]

Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4928#discussion_r148204398
  
    --- Diff: 
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/KafkaTopicPartitionState.java
 ---
    @@ -95,6 +95,10 @@ public final boolean isOffsetDefined() {
                return offset != 
KafkaTopicPartitionStateSentinel.OFFSET_NOT_SET;
        }
     
    +   public final boolean isSentinel() {
    --- End diff --
    
    nit: would `hasSentinelOffset` be a better name here?


---