[
https://issues.apache.org/jira/browse/FLINK-7778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16234042#comment-16234042
]
ASF GitHub Bot commented on FLINK-7778:
---------------------------------------
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4927
@StephanEwen
Regarding1) Curator 2.12 does not shade all of guava. This is the curation
relocation definition for guava:
```
<relocation>
<pattern>com.google</pattern>
<shadedPattern>org.apache.curator.shaded.com.google</shadedPattern>
<excludes>
<exclude>com.google.common.base.Function</exclude>
<exclude>com.google.common.base.Predicate</exclude>
<exclude>com.google.common.reflect.TypeToken</exclude>
</excludes>
</relocation>
```
The excluded classes are _not_ unused, as the `Function` class is used by
the `CuratorFramework`. So we still need to shade guava unfortunately.
As for 2), I'll take a look!
> Relocate ZooKeeper
> ------------------
>
> Key: FLINK-7778
> URL: https://issues.apache.org/jira/browse/FLINK-7778
> Project: Flink
> Issue Type: Sub-task
> Components: Build System
> Affects Versions: 1.4.0
> Reporter: Till Rohrmann
> Priority: Critical
> Fix For: 1.4.0
>
>
> If possible, then we should also try to relocate {{ZooKeeper}} in order to
> avoid dependency clashes between Flink's {{ZooKeeper}} and Hadoop's
> {{ZooKeeper}} dependency.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
