[ 
https://issues.apache.org/jira/browse/FLINK-7778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16234480#comment-16234480
 ] 

ASF GitHub Bot commented on FLINK-7778:
---------------------------------------

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/4927
  
    @zentol I like the changes!
    
    Last two points:
      1. Does it make sense to add only the non relocated guava classes in 
`flink-shaded-curator`? Meaning define a filter in the shading inclusion to 
only add `com.google.common.base.Function`, `com.google.common.base.Predicate`, 
and `com.google.common.reflect.TypeToken`?
    
      2. We can probably remove the parent project `flink-shaded-curator` and 
make the `flink-shaded-curator-recipes` the main project.
    



> Relocate ZooKeeper
> ------------------
>
>                 Key: FLINK-7778
>                 URL: https://issues.apache.org/jira/browse/FLINK-7778
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Build System
>    Affects Versions: 1.4.0
>            Reporter: Till Rohrmann
>            Assignee: Chesnay Schepler
>            Priority: Critical
>             Fix For: 1.4.0
>
>
> If possible, then we should also try to relocate {{ZooKeeper}} in order to 
> avoid dependency clashes between Flink's {{ZooKeeper}} and Hadoop's 
> {{ZooKeeper}} dependency.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to