[
https://issues.apache.org/jira/browse/FLINK-6434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16236174#comment-16236174
]
ASF GitHub Bot commented on FLINK-6434:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4937#discussion_r148571851
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/instance/SlotPoolTest.java
---
@@ -294,11 +296,11 @@ public void returnAllocatedSlot(Slot slot) {
}
}
- private static ResourceManagerGateway
createResourceManagerGatewayMock() {
+ static ResourceManagerGateway createResourceManagerGatewayMock() {
ResourceManagerGateway resourceManagerGateway =
mock(ResourceManagerGateway.class);
when(resourceManagerGateway
- .requestSlot(any(JobMasterId.class),
any(SlotRequest.class), any(Time.class)))
- .thenReturn(mock(CompletableFuture.class,
RETURNS_MOCKS));
+ .requestSlot(any(JobMasterId.class),
any(SlotRequest.class), any(Time.class)))
+ .thenReturn(mock(CompletableFuture.class,
RETURNS_MOCKS));
--- End diff --
Why not returning a proper `CompletableFuture` here?
> There may be allocatedSlots leak in SlotPool
> --------------------------------------------
>
> Key: FLINK-6434
> URL: https://issues.apache.org/jira/browse/FLINK-6434
> Project: Flink
> Issue Type: Bug
> Components: Cluster Management
> Reporter: shuai.xu
> Assignee: shuai.xu
> Priority: Major
> Labels: flip-6
>
> If the call allocateSlot() from Execution to Slotpool timeout, the job will
> begin to failover, but the pending request are still in SlotPool, if then a
> new slot register to SlotPool, it may be fulfill the outdated pending request
> and be added to allocatedSlots, but it will never be used and will never be
> recycled.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
