[
https://issues.apache.org/jira/browse/FLINK-8105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16258531#comment-16258531
]
ASF GitHub Bot commented on FLINK-8105:
---------------------------------------
GitHub user yew1eb opened a pull request:
https://github.com/apache/flink/pull/5034
[FLINK-8105][minor] Removed unnecessary null check
## What is the purpose of the change
Removed unnecessary null check
eg.
`if (value != null && value instanceof String)`
null instanceof String returns false, hence replaced the check with
`if (value instanceof String)`
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes /
**no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yew1eb/flink FLINK-8105
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5034.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5034
----
commit 4448369f3797beae7563df385eb0879213ee6abf
Author: yew1eb <[email protected]>
Date: 2017-11-19T16:50:57Z
[FLINK-8105][minor] Removed unnecessary null check
----
> Removed unnecessary null check
> ------------------------------
>
> Key: FLINK-8105
> URL: https://issues.apache.org/jira/browse/FLINK-8105
> Project: Flink
> Issue Type: Improvement
> Components: Checkstyle
> Affects Versions: 1.4.0
> Reporter: Hai Zhou UTC+8
> Assignee: Hai Zhou UTC+8
> Priority: Minor
> Fix For: 1.5.0
>
>
> eg.
> {code:java}
> if (value != null && value instanceof String)
> {code}
> null instanceof String returns false hence replaced the check with
> {code:java}
> if (value instanceof String)
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
