[ 
https://issues.apache.org/jira/browse/FLINK-8105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16259288#comment-16259288
 ] 

ASF GitHub Bot commented on FLINK-8105:
---------------------------------------

Github user greghogan commented on the issue:

    https://github.com/apache/flink/pull/5034
  
    IntelliJ reports 24 instances of "unnecessary 'null' check before 
'instanceof' expression".


> Removed unnecessary null check
> ------------------------------
>
>                 Key: FLINK-8105
>                 URL: https://issues.apache.org/jira/browse/FLINK-8105
>             Project: Flink
>          Issue Type: Improvement
>          Components: Checkstyle
>    Affects Versions: 1.4.0
>            Reporter: Hai Zhou UTC+8
>            Assignee: Hai Zhou UTC+8
>            Priority: Minor
>             Fix For: 1.5.0
>
>
> eg.
> {code:java}
> if (value != null && value instanceof String)
> {code}
> null instanceof String returns false hence replaced the check with
> {code:java}
> if (value instanceof String)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to