[
https://issues.apache.org/jira/browse/FLINK-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16259317#comment-16259317
]
ASF GitHub Bot commented on FLINK-7468:
---------------------------------------
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4559#discussion_r152008483
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/SpillableSubpartition.java
---
@@ -246,9 +246,9 @@ public int unsynchronizedGetNumberOfQueuedBuffers() {
@Override
public String toString() {
return String.format("SpillableSubpartition [%d number of
buffers (%d bytes)," +
- "finished? %s, read view? %s,
spilled? %s]",
- getTotalNumberOfBuffers(),
getTotalNumberOfBytes(), isFinished, readView != null,
- spillWriter != null);
+ "%d backlog, finished? %s, read view? %s,
spilled? %s]",
--- End diff --
`"%d buffers in backlog, finished (...)"` ?
`"backlog = %d, finished (...)"` ?
`"%d in backlog, finished (...)"` ?
`%d backlog` is a little bit cryptic.
> Implement sender backlog logic for credit-based
> -----------------------------------------------
>
> Key: FLINK-7468
> URL: https://issues.apache.org/jira/browse/FLINK-7468
> Project: Flink
> Issue Type: Sub-task
> Components: Network
> Reporter: zhijiang
> Assignee: zhijiang
> Fix For: 1.5.0
>
>
> This is a part of work for credit-based network flow control.
> Receivers should know how many buffers are available on the sender side (the
> backlog). The receivers use this information to decide how to distribute
> floating buffers.
> The {{ResultSubpartition}} maintains the backlog which only indicates the
> number of buffers in this subpartition, not including the number of events.
> The backlog is increased for adding buffer to this subpartition, and
> decreased for polling buffer from it.
> The backlog is attached in {{BufferResponse}} by sender as an absolute value
> after the buffer being transferred.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
