[
https://issues.apache.org/jira/browse/FLINK-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16269117#comment-16269117
]
ASF GitHub Bot commented on FLINK-7468:
---------------------------------------
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4559#discussion_r153564111
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/CancelPartitionRequestTest.java
---
@@ -174,19 +175,21 @@ public ResultSubpartitionView answer(InvocationOnMock
invocationOnMock) throws T
//
---------------------------------------------------------------------------------------------
- static class InfiniteSubpartitionView implements ResultSubpartitionView
{
+ static class InfiniteSubpartitionView extends ResultSubpartitionView {
private final BufferProvider bufferProvider;
private final CountDownLatch sync;
public InfiniteSubpartitionView(BufferProvider bufferProvider,
CountDownLatch sync) {
+ super(mock(ResultSubpartition.class));
+
this.bufferProvider = checkNotNull(bufferProvider);
this.sync = checkNotNull(sync);
}
@Override
- public Buffer getNextBuffer() throws IOException,
InterruptedException {
+ public Buffer getNextBufferInternal() throws IOException,
InterruptedException {
--- End diff --
make this `protected`
> Implement sender backlog logic for credit-based
> -----------------------------------------------
>
> Key: FLINK-7468
> URL: https://issues.apache.org/jira/browse/FLINK-7468
> Project: Flink
> Issue Type: Sub-task
> Components: Network
> Reporter: zhijiang
> Assignee: zhijiang
> Fix For: 1.5.0
>
>
> This is a part of work for credit-based network flow control.
> Receivers should know how many buffers are available on the sender side (the
> backlog). The receivers use this information to decide how to distribute
> floating buffers.
> The {{ResultSubpartition}} maintains the backlog which only indicates the
> number of buffers in this subpartition, not including the number of events.
> The backlog is increased for adding buffer to this subpartition, and
> decreased for polling buffer from it.
> The backlog is attached in {{BufferResponse}} by sender as an absolute value
> after the buffer being transferred.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
