[ 
https://issues.apache.org/jira/browse/FLINK-8118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16264138#comment-16264138
 ] 

ASF GitHub Bot commented on FLINK-8118:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5056#discussion_r152762409
  
    --- Diff: 
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSource.java
 ---
    @@ -68,6 +71,12 @@
        /** Descriptor for a rowtime attribute. */
        private List<RowtimeAttributeDescriptor> rowtimeAttributeDescriptors;
     
    +   /** The startup mode for the contained consumer (default is {@link 
StartupMode#GROUP_OFFSETS}). */
    +   protected StartupMode startupMode;
    --- End diff --
    
    should be `private`. We use `protected` setter methods to set optional 
parameters from the builder (see `proctimeAttribute`).


> Allow to specify the offsets of KafkaTableSources
> -------------------------------------------------
>
>                 Key: FLINK-8118
>                 URL: https://issues.apache.org/jira/browse/FLINK-8118
>             Project: Flink
>          Issue Type: New Feature
>          Components: Table API & SQL
>    Affects Versions: 1.4.0
>            Reporter: Timo Walther
>            Assignee: Xingcan Cui
>
> Right now the Kafka TableSources can only read from the current group offset. 
> We should expose the possibilities of the Kafka Consumer:
> https://ci.apache.org/projects/flink/flink-docs-release-1.4/dev/connectors/kafka.html#kafka-consumers-start-position-configuration



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to