[ 
https://issues.apache.org/jira/browse/FLINK-8118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16264136#comment-16264136
 ] 

ASF GitHub Bot commented on FLINK-8118:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5056#discussion_r152760280
  
    --- Diff: 
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSource.java
 ---
    @@ -121,6 +130,37 @@ public String getProctimeAttribute() {
                return rowtimeAttributeDescriptors;
        }
     
    +   /**
    +    * Returns a version-specific Kafka consumer with the start position 
configured.
    +    *
    +    * @param topic                 Kafka topic to consume.
    +    * @param properties            Properties for the Kafka consumer.
    +    * @param deserializationSchema Deserialization schema to use for Kafka 
records.
    +    * @return The version-specific Kafka consumer
    +    */
    +   public FlinkKafkaConsumerBase<Row> getKafkaConsumer(
    --- End diff --
    
    Should be `protected`


> Allow to specify the offsets of KafkaTableSources
> -------------------------------------------------
>
>                 Key: FLINK-8118
>                 URL: https://issues.apache.org/jira/browse/FLINK-8118
>             Project: Flink
>          Issue Type: New Feature
>          Components: Table API & SQL
>    Affects Versions: 1.4.0
>            Reporter: Timo Walther
>            Assignee: Xingcan Cui
>
> Right now the Kafka TableSources can only read from the current group offset. 
> We should expose the possibilities of the Kafka Consumer:
> https://ci.apache.org/projects/flink/flink-docs-release-1.4/dev/connectors/kafka.html#kafka-consumers-start-position-configuration



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to