[
https://issues.apache.org/jira/browse/FLINK-8145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265165#comment-16265165
]
ASF GitHub Bot commented on FLINK-8145:
---------------------------------------
GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/5064
[FLINK-8145][tests] fix various IOManagerAsync instances not being shut down
## What is the purpose of the change
Fix several unit tests using `IOManagerAsync` but not shutting it down
afterwards (not even in the failure-free case). The only thing cleaning them up
seems to be a shutdown handler attached to the JVM. Since each IOManagerAsync
is spawning a number of reader and writer threads, this may put a significant
burden on the tests.
## Brief change log
- add shutdown handlers via `@AfterClass` to
`AsynchronousBufferFileWriterTest`, `BufferFileWriterFileSegmentReaderTest`,
`BufferFileWriterReaderTest`, `HashTablePerformanceComparison`,
`FixedLengthRecordSorterTest`
- let `HashTableITCase`, `AbstractSortMergeOuterJoinIteratorITCase` test
methods use the static `ioManager` instead of creating new instances in some
test methods
- clean up manually in `HashTableTest`, `MassiveStringSorting`,
`MassiveStringValueSorting` (similar cleanup for the `MemoryManager` there)
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): **no**
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: **no**
- The serializers: **no**
- The runtime per-record code paths (performance sensitive): **no**
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: **no**
- The S3 file system connector: **no**
## Documentation
- Does this pull request introduce a new feature? **no**
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/NicoK/flink flink-8145
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5064.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5064
----
commit 7a0723b90fcefb8bf9c6e448e24db43758d0a1e2
Author: Nico Kruber <[email protected]>
Date: 2017-11-24T10:31:48Z
[FLINK-8145][tests] fix various IOManagerAsync instances not being shut down
----
> IOManagerAsync not properly shut down in various tests
> ------------------------------------------------------
>
> Key: FLINK-8145
> URL: https://issues.apache.org/jira/browse/FLINK-8145
> Project: Flink
> Issue Type: Bug
> Components: Tests
> Affects Versions: 1.4.0
> Reporter: Nico Kruber
> Assignee: Nico Kruber
>
> In various tests, e.g. {{AsynchronousBufferFileWriterTest}},
> {{BufferFileWriterReaderTest}}, or {{HashTableITCase}}, {{IOManagerAsync}}
> instances are used which are not shut down at all. The only thing cleaning
> them up seems to be a shutdown handler attached to the JVM. Since each
> {{IOManagerAsync}} is spawning a number of reader and writer threads, this
> may put a significant burden on the tests.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
