[
https://issues.apache.org/jira/browse/FLINK-8145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16287408#comment-16287408
]
ASF GitHub Bot commented on FLINK-8145:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5064#discussion_r156324988
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/operators/hash/HashTablePerformanceComparison.java
---
@@ -54,7 +55,12 @@
private final TypePairComparator<IntPair, IntPair> pairComparator = new
IntPairPairComparator();
- private IOManager ioManager = new IOManagerAsync();
+ private static final IOManager ioManager = new IOManagerAsync();
--- End diff --
this one is only used in a single test, don't think we need it as a field
> IOManagerAsync not properly shut down in various tests
> ------------------------------------------------------
>
> Key: FLINK-8145
> URL: https://issues.apache.org/jira/browse/FLINK-8145
> Project: Flink
> Issue Type: Bug
> Components: Tests
> Affects Versions: 1.4.0
> Reporter: Nico Kruber
> Assignee: Nico Kruber
>
> In various tests, e.g. {{AsynchronousBufferFileWriterTest}},
> {{BufferFileWriterReaderTest}}, or {{HashTableITCase}}, {{IOManagerAsync}}
> instances are used which are not shut down at all. The only thing cleaning
> them up seems to be a shutdown handler attached to the JVM. Since each
> {{IOManagerAsync}} is spawning a number of reader and writer threads, this
> may put a significant burden on the tests.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
