[
https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265297#comment-16265297
]
ASF GitHub Bot commented on FLINK-7406:
---------------------------------------
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4509#discussion_r152972414
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannelTest.java
---
@@ -715,4 +686,58 @@ private RemoteInputChannel createRemoteInputChannel(
initialAndMaxRequestBackoff._2(),
new
UnregisteredTaskMetricsGroup.DummyTaskIOMetricGroup());
}
+
+ private Callable recycleExclusiveBufferTask(RemoteInputChannel
inputChannel, int numExclusiveSegments) {
+ final List<Buffer> exclusiveBuffers = new
ArrayList<>(numExclusiveSegments);
+ // Exhaust all the exclusive buffers
+ for (int i = 0; i < numExclusiveSegments; i++) {
+ Buffer buffer = inputChannel.requestBuffer();
+ assertNotNull(buffer);
+ exclusiveBuffers.add(buffer);
+ }
+
+ return new Callable<Void>() {
+ @Override
+ public Void call() throws Exception {
+ for (Buffer buffer : exclusiveBuffers) {
+ buffer.recycle();
+ }
+
+ return null;
+ }
+ };
+ }
+
+ private Callable recycleFloatingBufferTask(BufferPool bufferPool, int
numFloatingBuffers) throws Exception {
+ final List<Buffer> floatingBuffers = new
ArrayList<>(numFloatingBuffers);
+ // Exhaust all the floating buffers
+ for (int i = 0; i < numFloatingBuffers; i++) {
+ Buffer buffer = bufferPool.requestBuffer();
+ assertNotNull(buffer);
+ floatingBuffers.add(buffer);
+ }
+
+ return new Callable<Void>() {
+ @Override
+ public Void call() throws Exception {
+ for (Buffer buffer : floatingBuffers) {
+ buffer.recycle();
+ }
+
+ return null;
+ }
+ };
+ }
+
+ private void submitTasksAndWaitResults(ExecutorService executor,
Callable[] tasks) throws Exception {
--- End diff --
maybe also rename to `submitTasksAndWaitForResults`
> Implement Netty receiver incoming pipeline for credit-based
> -----------------------------------------------------------
>
> Key: FLINK-7406
> URL: https://issues.apache.org/jira/browse/FLINK-7406
> Project: Flink
> Issue Type: Sub-task
> Components: Network
> Reporter: zhijiang
> Assignee: zhijiang
> Fix For: 1.5.0
>
>
> This is a part of work for credit-based network flow control.
> Currently {{PartitionRequestClientHandler}} receives and reads
> {{BufferResponse}} from producer. It will request buffer from {{BufferPool}}
> for holding the message. If not got, the message is staged temporarily and
> {{autoread}} for channel is set false.
> For credit-based mode, {{PartitionRequestClientHandler}} can always get
> buffer from {{RemoteInputChannel}} for reading messages from producer.
> The related works are:
> * Add the backlog of producer in {{BufferResponse}} message structure
> * {{PartitionRequestClientHandler}} requests buffer from
> {{RemoteInputChannel}} directly
> * {{PartitionRequestClientHandler}} updates backlog for
> {{RemoteInputChannel}}, and it may trigger requests of floating buffers from
> {{BufferPool}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
