[
https://issues.apache.org/jira/browse/FLINK-8124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16266584#comment-16266584
]
ASF GitHub Bot commented on FLINK-8124:
---------------------------------------
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/5073
Ah, I must have misread the original issue description. I think we should
not change the signature in such a way that it requires changing existing code.
I thought this was mainly about making the time triggers more relaxed so that
they accept a `Window` in addition to only `TimeWindow`.
> EventTimeTrigger (and other triggers) could have less specific generic types
> ----------------------------------------------------------------------------
>
> Key: FLINK-8124
> URL: https://issues.apache.org/jira/browse/FLINK-8124
> Project: Flink
> Issue Type: Improvement
> Components: Core
> Reporter: Cristian
> Priority: Minor
>
> When implementing custom WindowAssigners, it is possible to need different
> implementations of the {{Window}} class (other than {{TimeWindow}}). In such
> cases, it is not possible to use the existing triggers (e.g.
> {{EventTimeTrigger}}) because it extends from {{Trigger<Object, TimeWindow>}}
> which is (unnecessarily?) specific.
> It should be possible to make that class more generic by using
> {{EventTimeTrigger<T, W extends Window> extends Trigger<T, W>}} instead.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
