[
https://issues.apache.org/jira/browse/FLINK-8078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16267070#comment-16267070
]
ASF GitHub Bot commented on FLINK-8078:
---------------------------------------
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/5086
[FLINK-8078] Introduce LogicalSlot interface
## What is the purpose of the change
The LogicalSlot interface decouples the task deployment from the actual
slot implementation which at the moment is `SimpleSlot`. This is a helpful
step to introduce a different slot implementation for Flip-6.
## Brief change log
- Introduce `LogicalSlot`
- Replace `SimpleSlot` usage by `LogicalSlot`
- Let `SimpleSlot` implement the `LogicalSlot` interface
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink generalizeSlot
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5086.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5086
----
commit d30dde83548dbeff4249f3b57b67cdb6247af510
Author: Till Rohrmann <[email protected]>
Date: 2017-11-14T22:50:52Z
[FLINK-8078] Introduce LogicalSlot interface
The LogicalSlot interface decouples the task deployment from the actual
slot implementation which at the moment is Slot, SimpleSlot and SharedSlot.
This is a helpful step to introduce a different slot implementation for
Flip-6.
----
> Decouple Execution from actual slot implementation
> --------------------------------------------------
>
> Key: FLINK-8078
> URL: https://issues.apache.org/jira/browse/FLINK-8078
> Project: Flink
> Issue Type: Improvement
> Components: Distributed Coordination
> Affects Versions: 1.5.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Labels: flip-6
>
> In order to plug in a different slot implementation, we should introduce a
> slot interface which abstracts away the implementation details of
> {{SimpleSlot}} wrt {{Execution}}. The reason this is necessary is to provide
> a simpler slot implementation for Flip-6 since all allocation/release logic
> will go through the {{SlotPool}}. Thus, we no longer need the concurrent
> structure of {{Slot}}, {{SharedSlot}}, {{SimpleSlot}} and
> {{SlotSharingGroupAssignment}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
