Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r153457926
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientHandlerTest.java
---
@@ -208,8 +244,79 @@ public void testCancelBeforeActive() throws Exception {
client.cancelRequestFor(inputChannel.getInputChannelId());
}
+ /**
+ * Verifies that {@link RemoteInputChannel} is enqueued in the
pipeline, and
+ * {@link AddCredit} message is sent to the producer.
+ */
+ @Test
+ public void testNotifyCreditAvailable() throws Exception {
--- End diff --
Can you add some more tests (or adapt this one) with multiple
`inputChannel`s to verify the behaviour of
`WriteAndFlushNextMessageIfPossibleListener`. Also a test where this is
triggered via a channel writability change?
---
