[GitHub] flink pull request #4533: [FLINK-7416][network] Implement Netty receiver out...

[NicoK]

Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4533#discussion_r153448085
  
    --- Diff: 
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/NettyMessageSerializationTest.java
 ---
    @@ -158,6 +158,15 @@ public void testEncodeDecode() {
     
                        assertEquals(expected.getClass(), actual.getClass());
                }
    +
    +           {
    +                   NettyMessage.AddCredit expected = new 
NettyMessage.AddCredit(new ResultPartitionID(new 
IntermediateResultPartitionID(), new ExecutionAttemptID()), random.nextInt(), 
new InputChannelID());
    --- End diff --
    
    adapt if we only allow positive credits (see comment above)


---