Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5062#discussion_r153798592
  
    --- Diff: 
flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/Client.java
 ---
    @@ -133,7 +134,7 @@ public String getClientName() {
        }
     
        public CompletableFuture<RESP> sendRequest(final InetSocketAddress 
serverAddress, final REQ request) {
    -           if (shutDown.get()) {
    +           if (!clientShutdownFuture.compareAndSet(null, null)) {
    --- End diff --
    
    this should use ´clientShutdownFuture.get() != null` for clarity.


---

Reply via email to