Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r153789622
--- Diff:
flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/network/ClientTest.java
---
@@ -218,7 +225,18 @@ public void channelRead(ChannelHandlerContext ctx,
Object msg) throws Exception
assertEquals(expectedRequests, stats.getNumFailed());
} finally {
if (client != null) {
- client.shutdown();
+ try {
+
+ // todo here we were seeing this
problem:
+ //
https://github.com/netty/netty/issues/4357 if we do a get().
+ // this is why we now simply wait a bit
so that everything is
+ // shut down and then we check
+
+ client.shutdown().get(10L,
TimeUnit.SECONDS);
+ } catch (Exception e) {
+ e.printStackTrace();
+ }
+
Assert.assertTrue(client.isEventGroupShutdown());
--- End diff --
I would prefer if we would throw `e` in this and similar cases.
---
