[ 
https://issues.apache.org/jira/browse/FLINK-7880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16270831#comment-16270831
 ] 

ASF GitHub Bot commented on FLINK-7880:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5062#discussion_r153786058
  
    --- Diff: 
flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/Client.java
 ---
    @@ -300,7 +333,7 @@ private void handInChannel(Channel channel) {
                                        // Check shut down for possible race 
with shut down. We
                                        // don't want any lingering connections 
after shut down,
                                        // which can happen if we don't check 
this here.
    -                                   if (shutDown.get()) {
    +                                   if 
(!clientShutdownFuture.compareAndSet(null, null)) {
    --- End diff --
    
    for clarity we should call `get()` instead of `compareAndSet` since the 
setting part is a no-op anyway.


> flink-queryable-state-java fails with core-dump
> -----------------------------------------------
>
>                 Key: FLINK-7880
>                 URL: https://issues.apache.org/jira/browse/FLINK-7880
>             Project: Flink
>          Issue Type: Bug
>          Components: Queryable State, Tests
>    Affects Versions: 1.4.0
>            Reporter: Till Rohrmann
>            Assignee: Kostas Kloudas
>            Priority: Critical
>              Labels: test-stability
>
> The {{flink-queryable-state-java}} module fails on Travis with a core dump.
> https://travis-ci.org/tillrohrmann/flink/jobs/289949829



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to