Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r154888733
--- Diff:
flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/Client.java
---
@@ -133,7 +134,7 @@ public String getClientName() {
}
public CompletableFuture<RESP> sendRequest(final InetSocketAddress
serverAddress, final REQ request) {
- if (shutDown.get()) {
+ if (!clientShutdownFuture.compareAndSet(null, null)) {
--- End diff --
But the atomicity doesn't get you anything. Which case wouldn't be covered?
This check can only handle the case when sendRequest() is called after
shutdown(), regardless of whether you use compareAndSet() or get(), so it
shouldn't make a difference.
---
