Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5062#discussion_r154952648
--- Diff:
flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/network/AbstractServerTest.java
---
@@ -66,14 +65,15 @@ public void testServerInitializationFailure() throws
Throwable {
List<Integer> portList = new ArrayList<>();
portList.add(7777);
- try (
- TestServer server1 = new TestServer("Test
Server 1", new DisabledKvStateRequestStats(), portList.iterator());
- TestServer server2 = new TestServer("Test
Server 2", new DisabledKvStateRequestStats(), portList.iterator())
- ) {
+ try (TestServer server1 = new TestServer("Test Server 1", new
DisabledKvStateRequestStats(), portList.iterator())) {
server1.start();
- Assert.assertEquals(7777L,
server1.getServerAddress().getPort());
- server2.start();
+ List<Integer> occupiedPortList = new ArrayList<>();
+
occupiedPortList.add(server1.getServerAddress().getPort());
--- End diff --
could use `Collections.singletonList()` here
---
