Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5068#discussion_r154959996
  
    --- Diff: 
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/utils/TestFilterableTableSource.scala
 ---
    @@ -108,11 +108,15 @@ class TestFilterableTableSource(
       private val filterValues = new mutable.ArrayBuffer[Int]
     
       override def getDataSet(execEnv: ExecutionEnvironment): DataSet[Row] = {
    -    execEnv.fromCollection[Row](applyPredicatesToRows(data).asJava, 
getReturnType)
    +    execEnv
    +      .fromCollection[Row](applyPredicatesToRows(data).asJava, 
getReturnType)
    +      .name(explainSource())
    --- End diff --
    
    Would be great if you can be consistent with parenthesis. Sometimes it is 
`explainSource()` and sometimes `explainSource`.


---

Reply via email to