[GitHub] flink pull request #5068: [FLINK-8122] [table] Name all built-in table sinks...

[twalthr]

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5068#discussion_r154958279
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sinks/TableSink.scala
 ---
    @@ -45,6 +45,10 @@ trait TableSink[T] {
       /** Returns the types of the table fields. */
       def getFieldTypes: Array[TypeInformation[_]]
     
    +  /** Describes the table sink. */
    +  def explainSink(): String =
    --- End diff --
    
    This breaks compatibility with TableSinks implemented in Java. I'm fine 
with this. What do you think @fhueske?


---