Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5062#discussion_r155224312
  
    --- Diff: 
flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/network/ClientTest.java
 ---
    @@ -234,9 +236,14 @@ public void channelRead(ChannelHandlerContext ctx, 
Object msg) throws Exception
     
                                        client.shutdown().get(10L, 
TimeUnit.SECONDS);
                                } catch (Exception e) {
    -                                   e.printStackTrace();
    +                                   exc = e;
    +                                   
LOG.error(ExceptionUtils.stringifyException(e));
    --- End diff --
    
    use `LOG.error("An exception occurred while shutting down netty.", e)` 
instead


---

Reply via email to