[
https://issues.apache.org/jira/browse/FLINK-8216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16281434#comment-16281434
]
ASF GitHub Bot commented on FLINK-8216:
---------------------------------------
GitHub user bowenli86 opened a pull request:
https://github.com/apache/flink/pull/5130
[FLINK-8216] Unify test utils in flink-connector-kinesis
## What is the purpose of the change
currently there are a few ways to get a `Properties` object with required
fields (aws access key, aws secret key, aws region) for `KinesisConsumer` and
`KinesisProducer` in unit tests. We should unify them and provide a single util
to get that `Properties` object
## Brief change log
Unified all similar test utils to
`TestUtils.getPropertiesWithRequiredFields()`
## Verifying this change
This change is already covered by existing tests in
`flink-connector-kinesis`
## Does this pull request potentially affect one of the following parts:
none
## Documentation
none
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bowenli86/flink FLINK-8216
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5130.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5130
----
commit 33d435a504a354d51e93c6678d4c94e6eef58a68
Author: Bowen Li <[email protected]>
Date: 2017-12-07T07:22:50Z
[FLINK-8216] Unify test utils in flink-connector-kinesis
----
> Unify test utils in flink-connector-kinesis
> -------------------------------------------
>
> Key: FLINK-8216
> URL: https://issues.apache.org/jira/browse/FLINK-8216
> Project: Flink
> Issue Type: Improvement
> Components: Kinesis Connector
> Affects Versions: 1.5.0
> Reporter: Bowen Li
> Assignee: Bowen Li
> Priority: Minor
> Fix For: 1.5.0
>
>
> currently there are a few ways to get a Properties object with required
> fields (aws access key, aws secret key, aws region) for KinesisConsumer and
> KinesisProducer in unit tests. We should unify them and provide a single util
> to get that Properties object
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
