[
https://issues.apache.org/jira/browse/FLINK-8216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16281473#comment-16281473
]
ASF GitHub Bot commented on FLINK-8216:
---------------------------------------
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/5130#discussion_r155451196
--- Diff:
flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/testutils/TestUtils.java
---
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.streaming.connectors.kinesis.testutils;
+
+import
org.apache.flink.streaming.connectors.kinesis.config.AWSConfigConstants;
+
+import java.util.Properties;
+
+/**
+ * General test utils.
+ */
+public class TestUtils {
+ /**
+ * Get properties with Kinesis-required fields.
+ */
+ public static Properties getPropertiesWithRequiredFields() {
--- End diff --
I prefer the name `getStandardProperties` over this one. That makes it a
bit more coherent with the Kafka test code.
> Unify test utils in flink-connector-kinesis
> -------------------------------------------
>
> Key: FLINK-8216
> URL: https://issues.apache.org/jira/browse/FLINK-8216
> Project: Flink
> Issue Type: Improvement
> Components: Kinesis Connector
> Affects Versions: 1.5.0
> Reporter: Bowen Li
> Assignee: Bowen Li
> Priority: Minor
> Fix For: 1.5.0
>
>
> currently there are a few ways to get a Properties object with required
> fields (aws access key, aws secret key, aws region) for KinesisConsumer and
> KinesisProducer in unit tests. We should unify them and provide a single util
> to get that Properties object
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
