[ 
https://issues.apache.org/jira/browse/FLINK-8234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16291325#comment-16291325
 ] 

ASF GitHub Bot commented on FLINK-8234:
---------------------------------------

Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5168#discussion_r157026313
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/rest/util/RestMapperUtils.java
 ---
    @@ -33,10 +40,23 @@
                objectMapper.enable(
                        DeserializationFeature.FAIL_ON_IGNORED_PROPERTIES,
                        DeserializationFeature.FAIL_ON_NULL_FOR_PRIMITIVES,
    -                   DeserializationFeature.FAIL_ON_READING_DUP_TREE_KEY,
    -                   
DeserializationFeature.FAIL_ON_MISSING_CREATOR_PROPERTIES);
    +                   DeserializationFeature.FAIL_ON_READING_DUP_TREE_KEY);
                objectMapper.disable(
                        SerializationFeature.FAIL_ON_EMPTY_BEANS);
    +
    +           final SimpleModule jacksonFlinkModule = new SimpleModule();
    +
    +           final JavaType serializedValueWildcardType = objectMapper
    +                   .getTypeFactory()
    +                   .constructType(new TypeReference<SerializedValue<?>>() {
    +                   });
    +
    +           jacksonFlinkModule.addSerializer(new 
SerializedValueSerializer(serializedValueWildcardType));
    --- End diff --
    
    Could also be done using `@JsonSerialization` annotation


> Cache JobExecutionResult from finished JobManagerRunners
> --------------------------------------------------------
>
>                 Key: FLINK-8234
>                 URL: https://issues.apache.org/jira/browse/FLINK-8234
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Distributed Coordination
>    Affects Versions: 1.5.0
>            Reporter: Till Rohrmann
>            Assignee: Gary Yao
>              Labels: flip-6
>             Fix For: 1.5.0
>
>
> In order to serve the {{JobExecutionResults}} we have to cache them in the 
> {{Dispatcher}} after the {{JobManagerRunner}} has finished. The cache should 
> have a configurable size and should periodically clean up stale entries in 
> order to avoid memory leaks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to