[
https://issues.apache.org/jira/browse/FLINK-8234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16294868#comment-16294868
]
ASF GitHub Bot commented on FLINK-8234:
---------------------------------------
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5168#discussion_r157462859
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/job/JobExecutionResult.java
---
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.rest.messages.job;
+
+import org.apache.flink.api.common.JobID;
+import org.apache.flink.runtime.client.SerializedJobExecutionResult;
+import org.apache.flink.runtime.rest.messages.json.JobIDDeserializer;
+import org.apache.flink.runtime.rest.messages.json.JobIDSerializer;
+import org.apache.flink.util.SerializedValue;
+
+import
org.apache.flink.shaded.jackson2.com.fasterxml.jackson.annotation.JsonCreator;
+import
org.apache.flink.shaded.jackson2.com.fasterxml.jackson.annotation.JsonInclude;
+import
org.apache.flink.shaded.jackson2.com.fasterxml.jackson.annotation.JsonProperty;
+import
org.apache.flink.shaded.jackson2.com.fasterxml.jackson.databind.annotation.JsonDeserialize;
+import
org.apache.flink.shaded.jackson2.com.fasterxml.jackson.databind.annotation.JsonSerialize;
+
+import javax.annotation.Nullable;
+
+import java.util.Map;
+
+import static java.util.Objects.requireNonNull;
+
+/**
+ * This class is used to represent the information in {@link
JobExecutionResult} as JSON. In case
+ * of a job failure, no {@link JobExecutionResult} will be available. In
this case instances of this
+ * class will only store a {@link Throwable}.
+ */
+@JsonInclude(JsonInclude.Include.NON_NULL)
+public class JobExecutionResult {
+
+ private static final String FIELD_NAME_JOB_ID = "id";
+
+ private static final String FIELD_NAME_NET_RUNTIME = "net-runtime";
+
+ private static final String FIELD_NAME_ACCUMULATOR_RESULTS =
"accumulator-results";
+
+ private static final String FIELD_NAME_FAILURE_CAUSE = "failure-cause";
+
+ @JsonSerialize(using = JobIDSerializer.class)
+ @JsonDeserialize(using = JobIDDeserializer.class)
+ @JsonProperty(value = FIELD_NAME_JOB_ID, required = true)
+ private final JobID jobId;
+
+ @JsonProperty(FIELD_NAME_NET_RUNTIME)
+ private final Long netRuntime;
+
+ @JsonProperty(FIELD_NAME_ACCUMULATOR_RESULTS)
+ private final Map<String, SerializedValue<Object>> accumulatorResults;
+
+ @JsonProperty(FIELD_NAME_FAILURE_CAUSE)
+ private final Throwable throwable;
--- End diff --
Maybe only include the errorMessage to avoid ser/des issues.
> Cache JobExecutionResult from finished JobManagerRunners
> --------------------------------------------------------
>
> Key: FLINK-8234
> URL: https://issues.apache.org/jira/browse/FLINK-8234
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination
> Affects Versions: 1.5.0
> Reporter: Till Rohrmann
> Assignee: Gary Yao
> Labels: flip-6
> Fix For: 1.5.0
>
>
> In order to serve the {{JobExecutionResults}} we have to cache them in the
> {{Dispatcher}} after the {{JobManagerRunner}} has finished. The cache should
> have a configurable size and should periodically clean up stale entries in
> order to avoid memory leaks.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
