Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/5105#discussion_r157172734
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPool.java
---
@@ -179,7 +179,8 @@ public void setBufferPoolOwner(BufferPoolOwner owner) {
@Override
public Buffer requestBuffer() throws IOException {
try {
- return requestBuffer(false);
+ BufferBuilder bufferBuilder =
requestBufferBuilder(false);
+ return bufferBuilder != null ? bufferBuilder.build() :
null;
--- End diff --
Nope, size is always set manually in remaining calls.
Yes I know, but it took me almost a week to adapt tests so far for this
`BufferBuilder` (and `requestBuffer` is mocked ~60 times...). Can we postpone
finishing this refactor for a later time?
---
