[jira] [Commented] (FLINK-8274) Fix Java 64K method compiling limitation for CommonCalc

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/FLINK-8274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16294790#comment-16294790
 ] 

ASF GitHub Bot commented on FLINK-8274:
---------------------------------------

GitHub user Xpray opened a pull request:

    https://github.com/apache/flink/pull/5174

    [FLINK-8274][TableAPI & SQL] Fix Java 64K method compiling limitation…

    [FLINK-8274][TableAPI & SQL] Fix Java 64K method compiling limitation for 
CommonCalc'
    
    
    ## What is the purpose of the change
    
    The genereted code in ```CommonCalc``` consists of Three parts, reusable 
code per code, ```filterCondition.code``` and ```projection.code```, 
```projection.code``` is most likely the longest parts, this issue intend to 
split ```projection.code``` to split function calls
    
    ## Brief change log
    
      - *add a configuration to ```TableConfig```, which indicates the max 
length of generated code*
      - *the default value for maxGenerateCodeLength is 48k*
    
    ## Verifying this change
    
    
    This change is already covered by existing tests, such as:
    
    all tests that involve with  the ```CommonCalc```
    
    This change added tests and can be verified as follows:
    
      - *CalcWithSplitCodeGenITCase which set maxGenerateCodeLength to 1*
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): 
         no
      - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: 
        no
      - The serializers: 
        no
      - The runtime per-record code paths (performance sensitive): 
        no
      - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: 
        no
      - The S3 file system connector: 
        no
    ## Documentation
    
      - Does this pull request introduce a new feature? 
        no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Xpray/flink FLINK-8274

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5174.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5174
    
----
commit e8c697b284d708558debf6a790b817b2e30a1612
Author: Xpray <leonxp...@gmail.com>
Date:   2017-12-18T10:32:16Z

    [FLINK-8274][TableAPI & SQL] Fix Java 64K method compiling limitation for 
CommonCalc

----


> Fix Java 64K method compiling limitation for CommonCalc
> -------------------------------------------------------
>
>                 Key: FLINK-8274
>                 URL: https://issues.apache.org/jira/browse/FLINK-8274
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>            Reporter: Ruidong Li
>            Assignee: Ruidong Li
>
> For complex SQL Queries, the generated code for {code}DataStreamCalc{code}, 
> {code}DataSetCalc{code} may exceed Java's method length limitation 64kb.
>  
> This issue will split long method to several sub method calls.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)