[ 
https://issues.apache.org/jira/browse/FLINK-8292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16296442#comment-16296442
 ] 

ASF GitHub Bot commented on FLINK-8292:
---------------------------------------

GitHub user Matrix42 opened a pull request:

    https://github.com/apache/flink/pull/5180

    [FLINK-8292] Remove unnecessary force cast in DataStreamSource

    ## What is the purpose of the change
    
    Remove unnecessary force cast in DataStreamSource
    
    ## Brief change log
    
    *(for example:)*
      - *The TaskInfo is stored in the blob store on job creation time as a 
persistent artifact*
      - *Deployments RPC transmits only the blob storage reference*
      - *TaskManagers retrieve the TaskInfo from the blob cache*
    
    
    ## Verifying this change
    
    This change is already covered by existing tests, such as 
DataStreamTest.testParallelism()
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): ( no)
      - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: ( no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): ( no )
      - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no )
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable / docs / 
JavaDocs / not documented)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Matrix42/flink DataStreamSource

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5180.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5180
    
----
commit d5c55d2a73fdbcc0dfadd05ad87203ca70d64eac
Author: Matrix42 <[email protected]>
Date:   2017-12-19T08:20:39Z

    [FLINK-8292] Remove unnecessary force cast in DataStreamSource

----


> Remove unnecessary force cast in DataStreamSource
> -------------------------------------------------
>
>                 Key: FLINK-8292
>                 URL: https://issues.apache.org/jira/browse/FLINK-8292
>             Project: Flink
>          Issue Type: Improvement
>          Components: DataStream API
>            Reporter: Matrix42
>            Priority: Trivial
>             Fix For: 1.5.0, 1.4.1
>
>
> In DataStreamSource there is a cast can be replaced by retuen `this`



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to