[GitHub] flink pull request #5182: [FLINK-8162] [kinesis-connector] Emit Kinesis' mil...

[zentol]

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5182#discussion_r157907259
  
    --- Diff: 
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumer.java
 ---
    @@ -96,6 +100,14 @@ protected ShardConsumer(KinesisDataFetcher<T> 
fetcherRef,
                                                        SequenceNumber 
lastSequenceNum,
                                                        KinesisProxyInterface 
kinesis) {
                this.fetcherRef = checkNotNull(fetcherRef);
    +           MetricGroup kinesisMetricGroup = fetcherRef.getRuntimeContext()
    +                   .getMetricGroup()
    +                   .addGroup("Kinesis");
    +           kinesisMetricGroup
    --- End diff --
    
    use `addGroup("shard_id", subscribedShard.getShard().getShardId())` instead 
and register the metric on the returned group.


---