Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/5182#discussion_r158160866
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumer.java
---
@@ -96,6 +99,15 @@ protected ShardConsumer(KinesisDataFetcher<T> fetcherRef,
SequenceNumber
lastSequenceNum,
KinesisProxyInterface
kinesis) {
this.fetcherRef = checkNotNull(fetcherRef);
+ MetricGroup kinesisMetricGroup = fetcherRef.getRuntimeContext()
+ .getMetricGroup()
+ .addGroup("Kinesis")
--- End diff --
Do we really need this group? The metric is already bounded to the current
subtask, which should provide enough context that it is Kinesis-related since
we're the Kinesis consumer, no?
---
