Github user hequn8128 commented on the issue:
https://github.com/apache/flink/pull/4471
Hi, @twalthr , thanks for your review.
The pr has been updated according to your comments. It mainly contains the
following changes:
- Do some minor refactors in `UpdatingPlanChecker`, `NonWindowInnerJoin`
and tests
- As for indicator attributes
- Event-time attributes are considered to be not supported. When
executing the join, the join operator needs to make sure that no late data is
emitted. Window join makes it possible by holding back watermarks, but
non-window join is unbounded, so we don't know how much to hold back.
- Proctime attributes are supported to be outputted from join but can not
exist in join predicate. It seems there is no easy way to support proctime
attributes in join predicate. If we evaluate proctime in code generator, left
proctime will always equals right proctime, which makes `left.proctime >
right.proctime` always return false. Currently, users can cast proctime
attributes to long type if they want to do predicate. What do you think?
---
