[ 
https://issues.apache.org/jira/browse/FLINK-8289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16301835#comment-16301835
 ] 

ASF GitHub Bot commented on FLINK-8289:
---------------------------------------

Github user EronWright commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5190#discussion_r158545462
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/entrypoint/ClusterEntrypoint.java
 ---
    @@ -155,6 +156,7 @@ protected void runCluster(Configuration configuration) 
throws Exception {
                        // write host information into configuration
                        configuration.setString(JobManagerOptions.ADDRESS, 
commonRpcService.getAddress());
                        configuration.setInteger(JobManagerOptions.PORT, 
commonRpcService.getPort());
    +                   configuration.setString(RestOptions.REST_ADDRESS, 
commonRpcService.getAddress());
    --- End diff --
    
    This appears to be configuring the REST server's bind address, using the 
server address obtained from `AkkaRpcService`.   I don't understand the 
rationale, could you explain?


> The RestServerEndpoint should return the address with real ip when 
> getRestAdddress
> ----------------------------------------------------------------------------------
>
>                 Key: FLINK-8289
>                 URL: https://issues.apache.org/jira/browse/FLINK-8289
>             Project: Flink
>          Issue Type: Bug
>    Affects Versions: 1.5.0
>            Reporter: shuai.xu
>              Labels: flip-6
>
> Now when RestServerEndpoint.getRestAddress, it will return an address same 
> with the value of config rest.address, the default it 127.0.0.1:9067, but 
> this address can not be accessed from another machine. And the ip for 
> Dispatcher and JobMaster are usually dynamically, so user will configure it 
> to 0.0.0.0, and the getRestAddress will return 0.0.0.0:9067, this address 
> will be registered to YARN or Mesos, but this address can not be accessed 
> from another machine also. So it need to return the real ip:port for user to 
> access the web monitor anywhere.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to