[ 
https://issues.apache.org/jira/browse/FLINK-8289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16303119#comment-16303119
 ] 

ASF GitHub Bot commented on FLINK-8289:
---------------------------------------

Github user shuai-xu commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5190#discussion_r158627004
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/entrypoint/ClusterEntrypoint.java
 ---
    @@ -155,6 +156,7 @@ protected void runCluster(Configuration configuration) 
throws Exception {
                        // write host information into configuration
                        configuration.setString(JobManagerOptions.ADDRESS, 
commonRpcService.getAddress());
                        configuration.setInteger(JobManagerOptions.PORT, 
commonRpcService.getPort());
    +                   configuration.setString(RestOptions.REST_ADDRESS, 
commonRpcService.getAddress());
    --- End diff --
    
    I think what we want to get from the RestServerEndpoint is its server 
address. One way is to let its bind address to be the real ip of the machine. 
The common rpc address now is the real ip. 


> The RestServerEndpoint should return the address with real ip when 
> getRestAdddress
> ----------------------------------------------------------------------------------
>
>                 Key: FLINK-8289
>                 URL: https://issues.apache.org/jira/browse/FLINK-8289
>             Project: Flink
>          Issue Type: Bug
>    Affects Versions: 1.5.0
>            Reporter: shuai.xu
>              Labels: flip-6
>
> Now when RestServerEndpoint.getRestAddress, it will return an address same 
> with the value of config rest.address, the default it 127.0.0.1:9067, but 
> this address can not be accessed from another machine. And the ip for 
> Dispatcher and JobMaster are usually dynamically, so user will configure it 
> to 0.0.0.0, and the getRestAddress will return 0.0.0.0:9067, this address 
> will be registered to YARN or Mesos, but this address can not be accessed 
> from another machine also. So it need to return the real ip:port for user to 
> access the web monitor anywhere.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to