[
https://issues.apache.org/jira/browse/FLINK-8226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16305136#comment-16305136
]
ASF GitHub Bot commented on FLINK-8226:
---------------------------------------
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/5141#discussion_r158908424
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/SharedBuffer.java
---
@@ -82,9 +82,12 @@
private transient Map<K, SharedBufferPage<K, V>> pages;
+ private final transient List<SharedBufferEntry<K, V>> prunedEntries;
--- End diff --
Not sure about the potential advantages. See e.g. this answer on SO:
https://stackoverflow.com/a/18371813/4250114 . Plus the local variable is
easier to reason about.
Personally I am for the local variable, but if you feel this version is
better, will merge it as it is.
> Dangling reference generated after NFA clean up timed out SharedBufferEntry
> ---------------------------------------------------------------------------
>
> Key: FLINK-8226
> URL: https://issues.apache.org/jira/browse/FLINK-8226
> Project: Flink
> Issue Type: Bug
> Components: CEP
> Reporter: Dian Fu
> Assignee: Dian Fu
> Fix For: 1.5.0, 1.4.1
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
