[
https://issues.apache.org/jira/browse/FLINK-7797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16305856#comment-16305856
]
ASF GitHub Bot commented on FLINK-7797:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5140#discussion_r159013510
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/harness/StreamWindowJoinHarnessTest.scala
---
@@ -20,20 +20,25 @@ package org.apache.flink.table.runtime.harness
import java.lang.{Long => JLong}
import java.util.concurrent.ConcurrentLinkedQueue
+import org.apache.flink.api.java.operators.join.JoinType
import org.apache.flink.streaming.api.operators.co.KeyedCoProcessOperator
import org.apache.flink.streaming.api.watermark.Watermark
import org.apache.flink.streaming.runtime.streamrecord.StreamRecord
import
org.apache.flink.streaming.util.KeyedTwoInputStreamOperatorTestHarness
import org.apache.flink.table.api.Types
import
org.apache.flink.table.runtime.harness.HarnessTestBase.{RowResultSortComparator,
RowResultSortComparatorWithWatermarks, TupleRowKeySelector}
-import
org.apache.flink.table.runtime.join.{ProcTimeBoundedStreamInnerJoin,
RowTimeBoundedStreamInnerJoin}
+import org.apache.flink.table.runtime.join.{ProcTimeBoundedStreamJoin,
RowTimeBoundedStreamJoin}
import
org.apache.flink.table.runtime.operators.KeyedCoProcessOperatorWithWatermarkDelay
import org.apache.flink.table.runtime.types.CRow
import org.apache.flink.types.Row
import org.junit.Assert.assertEquals
import org.junit.Test
-class JoinHarnessTest extends HarnessTestBase {
+/**
+ * Since the runtime logic for different stream window joins are
identical, we only test on
+ * inner join.
+ */
+class StreamWindowJoinHarnessTest extends HarnessTestBase {
--- End diff --
We should also add harness tests for the outer joins. These are the only
tests that can test certain edge cases because the order of inputs can be
precisely controlled.
> Add support for windowed outer joins for streaming tables
> ---------------------------------------------------------
>
> Key: FLINK-7797
> URL: https://issues.apache.org/jira/browse/FLINK-7797
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Affects Versions: 1.4.0
> Reporter: Fabian Hueske
> Assignee: Xingcan Cui
>
> Currently, only windowed inner joins for streaming tables are supported.
> This issue is about adding support for windowed LEFT, RIGHT, and FULL OUTER
> joins.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
